contracts/deposit: cache parsed ABI and avoid per-call parsing #16061
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed unnecessary allocations and repeated ABI parsing in the hot path that processes deposit logs. Previously, UnpackDepositLogData converted the constant ABI string to a []byte, wrapped it in a bytes.Reader, and reparsed the ABI JSON on every call before unpacking into a []interface{}, incurring repeated allocations and type assertions. We now cache a parsed abi.ABI at package level using strings.NewReader and use UnpackIntoInterface to populate the generated DepositContractDepositEvent struct directly, eliminating the interface slice and assertions. The ABI is immutable and abi.ABI is safe for concurrent read-only reuse, so the cached instance is thread-safe. Behavior remains identical while reducing CPU and GC pressure during log processing.